refactor: get rid of managedResource
#3297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
force-pushed
the
3292-get-rid-managed-resources
branch
from
1140c50
to
6c4c12d
Compare
ndr-brt
force-pushed
the
3292-get-rid-managed-resources
branch
from
6c4c12d
to
ab3c3dc
Compare
jimmarino
approved these changes
Jul 13, 2023
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #3297 +/- ##
===========================================
- Coverage 72.20% 17.74% -54.46%
===========================================
Files 837 837
Lines 16867 16832 -35
Branches 951 948 -3
===========================================
- Hits 12178 2987 -9191
- Misses 4296 13767 +9471
+ Partials 393 78 -315
☔ View full report in Codecov by Sentry. |
ndr-brt
force-pushed
the
3292-get-rid-managed-resources
branch
from
146dca0
to
e23f408
Compare
bjungs
pushed a commit
to imec-int/edc
that referenced
this pull request
Aug 18, 2023
* refactor: get rid of managedResource * PR remarks * new dependencies file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
removed the
managedResourcefield onDataRequestand all the accessors because it had no more meaning in the current situationWhy it does that
refactoring
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #3292
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.